[tor-bugs] #3842 [Tor Client]: Missing signal/names option

[Tor Bug Tracker & Wiki]

#3842: Missing signal/names option
-----------------------------+----------------------------------------------
 Reporter:  atagar           |          Owner:                    
     Type:  enhancement      |         Status:  needs_review      
 Priority:  minor            |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client       |        Version:                    
 Keywords:  easy controller  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by rransom):

 Nice!

 I see (or don't see) one more buglet -- you didn't update the
 `getinfo_items` table, so your new code can never be called.  (Nick has
 made that mistake, too, so it's not that bad.)  Adding an entry in
 `getinfo_items` will also take care of adding “`signal/names`” to
 “`info/names`”.

 And then you might want to test this patch, in case I forgot one of the
 subtly important steps in adding a new `GETINFO` item.

 While you're looking at `getinfo_items`, please read the macros used to
 construct its contents; in particular, notice the use of ‘token pasting’
 to construct function names.  You probably shouldn't try to use token
 pasting for `signal_table`, but it's a good thing to know about.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3842#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online