[tor-bugs] #3842 [Tor Client]: Missing signal/names option
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sat Jan 21 10:46:15 UTC 2012
#3842: Missing signal/names option
-----------------------------+----------------------------------------------
Reporter: atagar | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: Tor: 0.2.4.x-final
Component: Tor Client | Version:
Keywords: easy controller | Parent:
Points: | Actualpoints:
-----------------------------+----------------------------------------------
Comment(by rransom):
Replying to [comment:5 nickm]:
> This looks reasonable; I like the table-driven approach.
>
> I wonder whether it wouldn't make sense to have the GETINFO values
constructed from the table; I'd say "not necessarily", but if not, we
should add a comment to the table saying that whenever we add a new value,
we need to make certain to add it to GETINFO signal/names. (Otherwise
we'll forget to add new values to signal/names)
Yes, the GETINFO value should be constructed from the table. (Otherwise,
there's no reason to remodel the rest of the code to be table-driven.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3842#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list