[tor-bugs] #4893 [Tor Client]: Rename inconsistent function and type names

[Tor Bug Tracker & Wiki]

#4893: Rename inconsistent function and type names
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 > Do we have this convention documented anywhere?

 Not explicitly; IMO it's implicit in all the other names we have.

 My objection to "env" is not that it's inaccurate but that it's
 meaningless. ''Everything'' can be construed as an environment,
 potentially.  A policy could be a policy_env_t; a connection could be a
 connection_env_t; a circuit could be a circuit_env_t; etc.

 It's the same argument for why you should name your objects things like
 circuit_t rather than circuit_object_t.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4893#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online