[tor-bugs] #4916 [Pluggable transport]: obfsproxy: wrong check of return value of proto_conn_create()

[Tor Bug Tracker & Wiki]

#4916: obfsproxy: wrong check of return value of proto_conn_create()
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn
     Type:  defect               |         Status:  new
 Priority:  normal               |      Milestone:     
Component:  Pluggable transport  |        Version:     
 Keywords:                       |         Parent:     
   Points:                       |   Actualpoints:     
---------------------------------+------------------------------------------
 In `network.c:open_outbound()` and `network.c:open_outbound_hostname()`:

 {{{
 ...
   newconn = proto_conn_create(conn->cfg);
   if (!conn) {
     log_warn("%s: failed to allocate state for outbound connection",
              conn->peername);
     bufferevent_free(buf);
     return NULL;
   }
 ...
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4916>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online