[tor-bugs] #4857 [Tor Hidden Services]: Disabling an HS with service-side rend circs in progress may produce ‘Internal Error’ log message

[Tor Bug Tracker & Wiki]

#4857: Disabling an HS with service-side rend circs in progress may produce
‘Internal Error’ log message
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:                    
     Type:  defect               |         Status:  new               
 Priority:  normal               |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 `rend_service_set_connection_addr_port` will fuss about open rend circs if
 the client tries to use them again:
 {{{
   service = rend_service_get_by_pk_digest(
                 circ->rend_data->rend_pk_digest);
   if (!service) {
     log_warn(LD_REND, "Couldn't find any service associated with pk %s on
 "
              "rendezvous circuit %d; closing.",
              serviceid, circ->_base.n_circ_id);
     return -1;
   }
 }}}

 But we probably shouldn't close already-open rendezvous circuits (and the
 open streams on them) when the service goes away; quieting this log
 message a bit should be enough.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4857#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online