[tor-bugs] #5229 [Ooni]: ooni-probe/bridget should make sure that random port numbers are not already taken

[Tor Bug Tracker & Wiki]

#5229: ooni-probe/bridget should make sure that random port numbers are not
already taken
---------------------+------------------------------------------------------
 Reporter:  karsten  |          Owner:  hellais                  
     Type:  defect   |         Status:  new                      
 Priority:  normal   |      Milestone:  Sponsor E: March 15, 2012
Component:  Ooni     |        Version:                           
 Keywords:           |         Parent:                           
   Points:           |   Actualpoints:                           
---------------------+------------------------------------------------------

Comment(by rransom):

 Replying to [ticket:5229 karsten]:
 > The bridget plugin of ooni-probe generates random Control and SOCKS
 ports between 49152 and 65535 and a random Tor data directory containing
 an int between 0 and 424242424242.  The ports are problematic here,
 because Tor won't start if a port is already in use.  We already ran into
 this case.  The plugin should make sure that a port number wasn't picked
 before, or it will conclude that a bridge is offline when it may be
 reachable.

 The plugin should use `SocksPort auto` and `ControlPort auto`.

 > The directory name generation could also be improved, e.g., by using an
 internal counter.

 Or generate a random string containing at least 128 bits of entropy.  (Use
 a real random number generator for this.)

 I do hope something cleans up old data directories.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5229#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online