[tor-bugs] #1667 [Tor Client]: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP request on the control port

[Tor Bug Tracker & Wiki]

#1667: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP
request on the control port
----------------------------+-----------------------------------------------
    Reporter:  nickm        |       Owner:                  
        Type:  enhancement  |      Status:  needs_revision  
    Priority:  trivial      |   Milestone:  Tor: unspecified
   Component:  Tor Client   |     Version:                  
  Resolution:               |    Keywords:  easy            
      Parent:               |      Points:                  
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by rransom):

  * status:  needs_review => needs_revision


Comment:

 TBB no longer includes an HTTP proxy.

 According to the message which Tor's SOCKSPort emits when someone attempts
 to use it as an HTTP proxy/server, you need to send a larger response in
 order to ensure that Internet Explorer will display it.

 Now the control port will silently eat commands with certain names.  It
 should send a reply.

 This still might send an HTTP-like response even if the HTTP-request-like
 line isn't the first thing send on a connection.

 `strcasecmp` should be the wrong function.  Perhaps you want
 `strcasecmpstart`?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1667#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online