[tor-bugs] #5191 [Tor Bridge]: mp->transports' contents types should not change by tme

[Tor Bug Tracker & Wiki]

#5191: mp->transports' contents types should not change by tme
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:     
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor Bridge  |        Version:     
 Keywords:              |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
 {{{
   /* The 'transports' list contains all the transports this proxy has
      launched.

      Before a managed_proxy_t reaches the PT_PROTO_COMPLETED phase,
      this smartlist contains a 'transport_t' for every transport it
      has launched.

      When the managed_proxy_t reaches the PT_PROTO_COMPLETED phase, it
      registers all its transports to the circuitbuild.c subsystem. At
      that point the 'transport_t's are owned by the circuitbuild.c
      subsystem.

      To avoid carrying dangling 'transport_t's in this smartlist,
      right before the managed_proxy_t reaches the PT_PROTO_COMPLETED
      phase we replace all 'transport_t's with strings of their
      transport names.

      So, tl;dr:
      When (conf_state != PT_PROTO_COMPLETED) this list carries
      (transport_t *).
      When (conf_state == PT_PROTO_COMPLETED) this list carries
      (char *).
    */
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5191>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online