[tor-bugs] #4865 [Tor Bridge]: managed obfsproxy cannot talk to tor on other than 127.0.0.1

[Tor Bug Tracker & Wiki]

#4865: managed obfsproxy cannot talk to tor on other than 127.0.0.1
------------------------+---------------------------------------------------
 Reporter:  wwaites     |          Owner:  asn               
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  needs_revision => needs_review


Comment:

 Please see `bug4865` in `https://git.gitorious.org/mytor/mytor.git`.

 Consider the following:

 a) I'm not super-sure about how `config.c:configured_ports` works. In
 `get_first_listener_addrport_string()`, I basically followed the logic of
 `router_get_advertised_or_port()`.

 b) Since `93414707aec510c253cf150b654b04dab45cf9e9`,
 ''set_managed_proxy_environment() can't fail anymore''. I'm not sure how
 to handle `get_first_listener_addrport_string()` fails. I'm currently
 asserting its return value. I don't think this is the correct solution. I
 didn't have time to think of something else.

 c) I did the following tests:
 {{{
 orport auto
 --
 orport 5555
 --
 ORPort auto
 ORListenAddress 192.168.2.1:10001
 --
 ORPort auto
 ORListenAddress 192.168.2.1:10001
 ORListenAddress 192.168.2.1:10000
 --
 ORPort 5555
 ORListenAddress 192.168.2.1:10001
 ORListenAddress 192.168.2.1:10000
 }}}
 the results seem correct. I tested it by running a managed proxy with a
 logfile on debug severity, and checking the environment variable logs.

 My suggestion is that if you like the code, and you have some time to test
 it, you can merge it. If you don't have the time to test it, I would like
 to do some more testing before merging.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4865#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online