[tor-bugs] #5105 [Tor Bridge]: set_managed_proxy_environment should be OS-independent

[Tor Bug Tracker & Wiki]

#5105: set_managed_proxy_environment should be OS-independent
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Looks good modulo #5082 issues (whatever they were) and of course the
 #5114 changes.

 wrt 9101c255914d68801c3a075c2ebfdc4dd267d734:

  * Technically, calloc(0,0)  should be legal -- or at the very least, it
 shouldn't be a divide-by-zero error.

 wrt later stuff:

  * Maybe it would be easier to have
 get_current_process_environment_variables() return a list containing heap-
 allocated copies of the environment variables?  That way we wouldn't need
 so much bookkeeping to remember what was safe to free and what wasn't, and
 we could eliminate the possibility of an entire category of error.

 In general:

  * Yeah, some unit tests would be great.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5105#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online