[tor-bugs] #5114 [Tor Client]: Environ not available on all versions of OS X, segfaults tor with obfsproxy

[Tor Bug Tracker & Wiki]

#5114: Environ not available on all versions of OS X, segfaults tor with obfsproxy
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by Sebastian):

 I mostly like it, except the comment " /* OSX 10.6 and later appear to
 need this. */" is a bit misleading. It seems we need this for OS X 10.7
 when building a mostly static Tor with backwards compatibility for 10.6.
 There might be more subtleties as to when the bug exactly applies, but
 that is the explanation I came up with (and this is also why I didn't
 notice the problem when I wrote the original patch).

 Also it won't compile on FreeBSD, because we need extern char **environ
 there. I pushed a bug5114 branch with an update, check it out please?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5114#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online