[tor-bugs] #5082 [Tor Client]: Tor cleans out environment before launching obfsproxy

[Tor Bug Tracker & Wiki]

#5082: Tor cleans out environment before launching obfsproxy
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  task        |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by Sebastian):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 arma]:
 > Does obfsproxy actually need HOME or PATH? I guess there's a question of
 which one should try to reconstruct it if it isn't defined. But I think
 currently it doesn't, so maybe we don't need to answer that question yet.

 At least currently, it doesn't. Needing HOME would be quite strange indeed
 for a daemon at least. And what would it do with PATH?

 > Is it dangerous to pass Tor's env vars to obfsproxy? I'm not sure. I
 think the benefits outweight the risks.

 I can't think of a reason why it'd be dangerous.

 > You'll definitely want to change the sentence "We can do this only if
 the spec change to require HOME and PATH to be set is accepted" because it
 implies that you want to change the spec to require HOME and PATH to be
 set.

 fixed. that doesn't belong in the changelog anyway.

 > I'd suggest a follow-up cleanup commit to get rid of the r, and change
 the function to return a void, clean up launch_managed_proxy() so it knows
 set_managed_proxy_environment() can't fail, etc.

 added

 > I have not evaluated the fiddly pointer arithmetic yet.

 also changed as suggested on irc.

 fixup + follow up commit added.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5082#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online