[tor-bugs] #5095 [Tor Client]: Setting __ReloadTorrcOnSIGHUP=0 breaks logrotate

[Tor Bug Tracker & Wiki]

#5095: Setting __ReloadTorrcOnSIGHUP=0 breaks logrotate
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 Vidalia copied a feature from TorK in its 0.2.16 release:
 {{{
   o Sets __ReloadTorrcOnSIGHUP to 0 if SAVECONF failed, which means
     the user can't write the torrc file. Fixes bug 4833.
 }}}

 The bug that it fixed was that if Vidalia does a saveconf that fails (e.g.
 because Tor can't write to /etc/tor/torrc), and Vidalia has setconf
 something different from the torrc, then Vidalia will setconf
 ReloadTorrcOnSIGHUP to 0 to prevent a silent and confusing clobbering of
 Tor's config when the daily hup happens.

 The bug that it introduces, though, is that this daily hup typically
 involves a logrotate, and now hup is mysteriously not going to open any
 new logs.

 (I'm not sure which milestone to set here -- it's a bug that will affect
 Tor 0.2.2 also, but I'm wary of invasive fixes on 0.2.2 at this point.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5095>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online