[tor-bugs] #5072 [Obfsproxy]: obfsproxy assertion failure src/network.c:726: down->buffer == bev

[Tor Bug Tracker & Wiki]

#5072: obfsproxy assertion failure src/network.c:726: down->buffer == bev
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn
     Type:  defect     |         Status:  new
 Priority:  major      |      Milestone:     
Component:  Obfsproxy  |        Version:     
 Keywords:             |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------

Comment(by asn):

 If `bug5072_v2` stops the crashing, check out branch `bug5072_v3`. It
 stops the annoying "Oh no you didn't" messages.

 It simply doesn't reassign the read callback on `error_or_eof()`. That's
 the behavior of the old `error_or_eof()`, before #3613.

 The bug that `bug5072_v2` and `bug5072_v3` are dodging is:
 {{{
 static void
 error_or_eof(conn_t *conn)
 {
 ...
   bev_flush = (conn == circ->upstream) ? circ->downstream->buffer
                                        : circ->upstream->buffer;
 ...
   bufferevent_setcb(bev_flush, bev_flush->readcb,
                     conn_free_on_flush, flush_error_cb, conn);
 }
 }}}
 in the case where `bev_flush->readcb == downstream_read_cb`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5072#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online