[tor-bugs] #5069 [Obfsproxy]: obfsproxy log file has no timestamps

[Tor Bug Tracker & Wiki]

#5069: obfsproxy log file has no timestamps
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:  asn         
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  Obfsproxy  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by arma):

 It should be <time.h>, not "time.h". <> is for system headers, and "" is
 for your own headers.

 When you call strftime, you should say sizeof(ts) rather than 21.
 Otherwise you're asking for troubles later when somebody changes one 21
 but not the other.

 Why do you have a T in the middle of the timestamp, and a Z at the end?
 The Z might be for Zulu I guess?

 In general I'm alarmed by the lack of autoconf lines to search for
 <time.h> vs <sys/time.h>, and by the C++ approach of declaring variables
 in the middle of code -- if obfsproxy's build process had more warnings
 enabled it would warn a lot.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5069#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online