[tor-bugs] #5053 [Tor Bridge]: Fix IPv6 implementation for bridge statistics

[Tor Bug Tracker & Wiki]

#5053: Fix IPv6 implementation for bridge statistics
------------------------+---------------------------------------------------
 Reporter:  karsten     |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Ok, and now for the actual substance:
 {{{
 -      if (tor_inet_aton((TO_CONN(conn))->address, &in)) {
 ...
 +    geoip_note_client_seen(act, &TO_CONN(conn)->addr, time(NULL));
 }}}

 Unfortunately, you've just been bitten by the "addr might be different
 from address" bug. "address" is where we store where we think the client
 is. "addr" is what IP address the connection came from.

 See for example http_set_address_origin() for how they can become
 different.

 The other case that comes to mind for how they can become different is for
 begindir requests. See
 {{{
       address = tor_dup_addr(&or_circ->p_conn->real_addr);
 }}}
 and
 {{{
     if (or_circ->p_conn && !tor_addr_is_null(&or_circ->p_conn->real_addr))
       tor_addr_copy(&n_stream->_base.addr, &or_circ->p_conn->real_addr);
 }}}
 in connection_exit_begin_conn().

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5053#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online