[tor-bugs] #7802 [Tor]: Remove PathBias use of timestamp_dirty

[Tor Bug Tracker & Wiki]

#7802: Remove PathBias use of timestamp_dirty
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:                    
     Type:  enhancement      |         Status:  new               
 Priority:  normal           |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor              |        Version:                    
 Keywords:  MikePerry201212  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
 Instead of using timestamp_dirty as a signal for "circuit use" in the
 pathbias code, we should create a dedicated path_state_t state
 (PATH_STATE_USE_ATTEMPTED).

 It's also debatable as to if we should *remove* the additional
 timestamp_dirty markings I added in #7157. The most controversial addition
 was marking freshly cannibalized circuits as dirty. While this seems to
 make sense to me (do we really want to use cannibalized circuits for any
 random stream?), it may have subtle impacts on the proper use of GENERAL
 purpose circuits that get cannibalized during predictive circuit building
 or other cases involving hidden services.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7802>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online