[tor-bugs] #7202 [Tor]: Implement ntor handshake or its successor

[Tor Bug Tracker & Wiki]

#7202: Implement ntor handshake or its successor
--------------------------------+-------------------------------------------
 Reporter:  karsten             |          Owner:                    
     Type:  project             |         Status:  needs_review      
 Priority:  normal              |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                 |        Version:                    
 Keywords:  SponsorZ tor-relay  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------

Comment(by asn):

 Super quick and completely incomplete review:

 * Maybe in `curve25519_public_key_isok()` you could use
 `tor_mem_is_zero()`? OTOH, maybe you want to explicitly show how the point
 at infinity looks like.

 * You forgot to check the retval of `crypto_rand()` in one or two
 occasions.

 * What is the XXXX added in `circuit_finish_handshake()`?

 * Shouldn't `parse_create2_payload()` check that `p_len` is larger (or
 equal) than 4 before doing `get_uint16()` and `p_len - 4`?

 * It's kind of weird looking at `parse_create2_payload()` parsing
 `EXTEND2` cells. Maybe `parse_create2_payload()` should be renamed, or at
 least specify that it's capable of parsing `EXTEND2` in its documentation?

 (The branch is huge and I haven't had time to review most of it. I hope to
 look more at it the following days.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7202#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online