[tor-bugs] #572 [Tor]: fallback-consensus file impractical to use

[Tor Bug Tracker & Wiki]

#572: fallback-consensus file impractical to use
-----------------------------------------------------------------------------+
 Reporter:  arma                                                             |           Type:  enhancement
   Status:  needs_review                                                     |       Priority:  major      
Milestone:  Tor: 0.2.4.x-final                                               |      Component:  Tor        
  Version:  0.2.0.9-alpha                                                    |     Resolution:  None       
 Keywords:  performance bootstrap dirauth-dos-resistance prop206 tor-client  |         Parent:  #2664      
   Points:                                                                   |   Actualpoints:             
-----------------------------------------------------------------------------+

Comment(by andrea):

 Begin code review:

 How will we pick the fallback servers/how long is the list expected to be?
 In 5c51b3f1f0d4c394392aa6fce89bbe0960117771, for example, you're
 introducing router_get_fallback_dirserver_by_digest() that searches a
 smartlist, which was fine for the short list of trusted authorities, but
 in comments further up on this ticket I'm seeing numbers like 500 servers
 being bandied about, which makes me a bit nervous about linear-time
 searches.  Is this going to be so infrequent an operation it isn't worth
 worrying about, though?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/572#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online