[tor-bugs] #7708 [Tor]: connection_handle_write_impl mishandles TOR_TLS_WANT_WRITE

[Tor Bug Tracker & Wiki]

#7708: connection_handle_write_impl mishandles TOR_TLS_WANT_WRITE
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  major      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor        |        Version:                    
 Keywords:  tor-relay  |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 I need to think of some way to test this, and look for more  cases where
 we should be writing but aren't.

 Maybe there should be a
 connection_should_be_writing/connection_should_be_reading function pair
 that we use to check whether a connection should be reading/writing, and
 if it isn't, we log a bug. That could be hard to get right.  But maybe it
 would be a worthwhile thing. Otherwise, I worry that we could have more
 cases like this.

 I wonder if I can provoke this on a testing network on purpose by setting
 SO_SNDBUF and/or SO_RCVBUF very low.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7708#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online