[tor-bugs] #7341 [Tor]: circuit_expire_building applies CBT in twisted ways on hidden service circuits

[Tor Bug Tracker & Wiki]

#7341: circuit_expire_building applies CBT in twisted ways on hidden service
circuits
-----------------------------------------+----------------------------------
 Reporter:  mikeperry                    |          Owner:                    
     Type:  defect                       |         Status:  needs_review      
 Priority:  normal                       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                          |        Version:                    
 Keywords:  tor-client, MikePerry201212  |         Parent:                    
   Points:                               |   Actualpoints:  25                
-----------------------------------------+----------------------------------
Changes (by mikeperry):

  * status:  new => needs_review
  * actualpoints:  16 => 25


Comment:

 This is fixed in the single commit at the tip of mikeperry/bug7341. Note
 that that branch is based off of mikeperry/209-path-bias-changes, since I
 tested them in combination.

 See the changes file for a summary, but it's basically what we agreed on.
 I implemented "Launch in parallel on timeout" for the intro case.

 Incidentally, Roger had already coded the "launch timed out intro circuits
 in parallel" change back in 2008, but something prevented his code from
 exercising. I ripped his code out, and consolidated it in
 circuit_expire_building() and rend_client_introduction_acked(), which is a
 much better place for it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7341#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online