[tor-bugs] #7664 [Ooni]: ooniprobe decks do not appear to work

[Tor Bug Tracker & Wiki]

#7664: ooniprobe decks do not appear to work
------------------------+---------------------------------------------------
    Reporter:  ioerror  |       Owner:  hellais
        Type:  defect   |      Status:  closed 
    Priority:  normal   |   Milestone:         
   Component:  Ooni     |     Version:         
  Resolution:  fixed    |    Keywords:         
      Parent:           |      Points:         
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by hellais):

  * status:  needs_revision => closed
  * resolution:  => fixed


Comment:

 Replying to [comment:5 ioerror]:
 > Ah - that was unclear - I thought that was the suggest way! I guess it
 isn't for threaded Twisted plugins... :(
 >
 > I think we should overload that stop method in plugins such that we
 can't have this issue again. Really, I think we should have helper classes
 that ensure that people aren't calling Twisted directly but rather
 methods/functions that take these little details into account.
 >
 > I'll give it a try and see how it goes.

 Well, you should always be using a test template, though there not a test
 template (yet) for command line scripts.

 I opened a ticket on it here:
 https://trac.torproject.org/projects/tor/ticket/7685

 Overriding the twisted reactor.stop method is not a clean solution as the
 reactor.stop and reactor.start are the only two functions you should not
 be calling.

 Writing tests from scratch should only be done if you know what you are
 doing, for everything else there is a test template that exposes a
 simplified API.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7664#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online