[tor-bugs] #7669 [Tor]: SIZEOF_INTPTR_T not defined in msvc builds

[Tor Bug Tracker & Wiki]

#7669: SIZEOF_INTPTR_T not defined in msvc builds
-----------------------+----------------------------------------------------
 Reporter:  ultramage  |          Owner:     
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:     
Component:  Tor        |        Version:     
 Keywords:  msvc       |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------
 Change [https://gitweb.torproject.org/tor.git/commit/1bfda600 1bfda600]
 added a block of helper code to src/common/compat.h that assumes
 SIZEOF_INTPTR_T is defined. While this is the case for configure-driven
 builds (defines available since
 [https://gitweb.torproject.org/tor.git/commit/8aebd83a 2004]), for the
 prepared win32 config the define is nowhere to be found. This causes a
 compilation error.

 I looked and saw that torint.h introduces type intptr_t when HAVE_INTPTR_T
 is not present. Also, it does {{{#if (SIZEOF_INTPTR_T != 0) #define
 HAVE_INTPTR_T}}}, so just defining it in orconfig.h would actually break
 this code. My first guess is that torint.h should define the sizeof at the
 moment it adds the intptr_t typedef. There might be better solutions.

 PS: uintptr_t should be dealt with as well.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7669>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online