[tor-bugs] #7063 [Flashproxy]: Make a query parameter to control opt-in/opt-out

[Tor Bug Tracker & Wiki]

#7063: Make a query parameter to control opt-in/opt-out
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  dcf           
     Type:  enhancement  |         Status:  needs_revision
 Priority:  major        |      Milestone:                
Component:  Flashproxy   |        Version:                
 Keywords:               |         Parent:  #7166         
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by aallai):

  * status:  new => needs_revision


Comment:

 I have an attempt at this in the opt-in branch of
 https://github.com/aallai/flashproxy.git.

 Tested in Chrome, Safari, IE 9 and Firefox. I just remembered IE < 8 uses
 attachEvent instead of addEventListener, so we don't support them yet. I
 should fix that up tomorrow.

 You can view the page at http://cs.mcgill.ca/~aallai2/options.html

 Some details I wasn't sure about:

 - Name and expiration date on the cookie. These are variables in
 options.js.

 - Where the options page is hosted. Right now the link assumes it is in
 the same directory as the embed.html/flashproxy.js files.

 - top-gradient.gif is an image used for the background of
 crypto.stanford.edu. Don't know if we want non-essential images in the
 repository.

 - Pop-up window. I noticed IE has a handy option to keep javascript from
 opening windows. I don't know how many people have this turned on, but I
 went for a regular link to be safe.

 Let me know how it is.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7063#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online