[tor-bugs] #6691 [Compass]: BaseFilter isn't really an abstract class... yet

[Tor Bug Tracker & Wiki]

#6691: BaseFilter isn't really an abstract class... yet
---------------------+------------------------------------------------------
 Reporter:  neena    |          Owner:  gsathya 
     Type:  defect   |         Status:  assigned
 Priority:  trivial  |      Milestone:          
Component:  Compass  |        Version:          
 Keywords:           |         Parent:          
   Points:           |   Actualpoints:          
---------------------+------------------------------------------------------

Comment(by karsten):

 Replying to [comment:2 neena]:
 > Replying to [comment:1 gsathya]:
 > > I  wonder if abstract classes even make sense in a dynamically typed
 language. I'd be all for removing @abstractmethod instead of adding more
 abstract stuff. What do you think?
 >
 > I would add the __metaclass__. Though, I don't feel too strongly about
 it.

 Hmm, why am I cc'ed?  To me as a non-Pythonian, Sathya's statement makes
 sense.  But maybe that's because I don't know what `__metaclass__` does.
 Anyway, I think I'll leave this ticket to the Python developers and will
 review/merge whatever Sathya comes up with. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6691#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online