[tor-bugs] #6653 [EFF-HTTPS Everywhere]: checkForBuggyDefaults has wrong for loop (was: laster master eeffa553bbb50bb0b375e1c969f014a6c4b3a841 forgets disabled rules)

Tue Aug 28 11:06:17 UTC 2012

#6653: checkForBuggyDefaults has wrong for loop
----------------------------------+-----------------------------------------
 Reporter:  federico              |          Owner:  pde
     Type:  defect                |         Status:  new
 Priority:  major                 |      Milestone:     
Component:  EFF-HTTPS Everywhere  |        Version:     
 Keywords:  rules disable         |         Parent:     
   Points:                        |   Actualpoints:     
----------------------------------+-----------------------------------------

Comment(by federico):

 after some debugging, I've found the "for (rulename in shouldBeOff)" is
 wrong as "for...in" iterates over the index of the array
 the bug caused https everywhere to always reset the active status of all
 rules

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6653#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online