[tor-bugs] #6690 [Tor Client]: compare_tor_addr_to_addr_policy assertion error

[Tor Bug Tracker & Wiki]

#6690: compare_tor_addr_to_addr_policy assertion error
------------------------+---------------------------------------------------
 Reporter:  mr-4        |          Owner:                     
     Type:  defect      |         Status:  new                
 Priority:  critical    |      Milestone:  Tor: 0.2.2.x-final 
Component:  Tor Client  |        Version:  Tor: 0.2.3.15-alpha
 Keywords:              |         Parent:                     
   Points:              |   Actualpoints:                     
------------------------+---------------------------------------------------
Changes (by nickm):

  * priority:  normal => critical
  * milestone:  Tor: 0.2.3.x-final => Tor: 0.2.2.x-final


Comment:

 Okay, looking through the code, we need fixes as follows:

   * Replace the assertion with "if (port == 0) return
 ADDR_POLICY_REJECTED;"
   * Maybe, reject any routerstatus with or_port == 0.  At least
 authorities should do this.

 A pseudonymous friend reports that there's a remote DOS opportunity
 against and by directory servers here, so we should treat this as pretty
 urgent.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6690#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online