[tor-bugs] #6524 [Tor Client]: [PATCH] move to non-recursive make

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu Aug 23 16:48:40 UTC 2012


#6524: [PATCH] move to non-recursive make
-------------------------+--------------------------------------------------
 Reporter:  stewart      |          Owner:  stewart           
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client   |        Version:  Tor: unspecified  
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 I've put all of these in a branch called "bug6524" in my public
 repository; there are links to my public repository at
 https://gitweb.torproject.org/nickm/tor.git .  I split up your last commit
 into two before adding it.

 I'm using Fedora 17; my autotools packages are up-to-date. (I have
 autoconf 2.68 and automake 1.11.3).

 I checked out that branch, then did "git clean -xf" to make sure I didn't
 have any bogons lying around. Then I tried "sh autogen.sh; ./configure;
 make".

 I got a build log that finally failed with:
 {{{
 /usr/bin/mkdir -p doc
   GEN    doc/tor.html
   GEN    doc/tor.html
 config.status: error: cannot find input file: `doc/tor.html.in'
 make[1]: *** [doc/tor.html] Error 1
 make[1]: Leaving directory `/home/nickm/src/tor'
 }}}

 and I noticed that there were no build rules to actually say that
 doc/tor.html depended on doc/tor.html.in .  So I tried adding this line to
 doc/include.am :

 {{{
 $(doc_DATA) : $(html_in)
 }}}

 And so far it seems to work.  Running more tests now.  Does the above
 addition look okay to you?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6524#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list