[tor-bugs] #6538 [Tor Client]: Use bit-twiddling tricks to make choose-by-bandwith algorithm even more time-invariant

[Tor Bug Tracker & Wiki]

#6538: Use bit-twiddling tricks to make choose-by-bandwith algorithm even more
time-invariant
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by arma):

 Looking at bug6538_023:

 {{{
      log_warn(LD_BUG, "Round-off error in computing bandwidth had an
 effect on "
               " which router we chose. Please tell the developers. "
 }}}
 is more likely to trigger now, since we make it all the way through the
 loop each time -- even though in nearly none of these cases does it
 actually have an effect on which router we chose? I recognize this is a
 potential problem with the original fix, not this one (unless I'm wrong).

 "incancations"

 More generally, this appears to be a complex tweak to a theoretical issue
 that is theoretically mostly solved in what we already merged? It includes
 messings to our autoconf and lots of new code. Why is it scheduled for
 0.2.3? Or said another way, is the risk/reward ratio here suitable for
 forcing it on all wheezy users at the next rc? I see the risk as being
 somewhat low and the reward as being very low.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6538#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online