[tor-bugs] #6341 [Tor Relay]: connection_or_flush_from_first_active_circuit() does wrong thing when ewma_enabled

[Tor Bug Tracker & Wiki]

#6341: connection_or_flush_from_first_active_circuit() does wrong thing when
ewma_enabled
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 {{{
 15:28 < armadev> re 6341, we have either a huge bug in shadow that
 sometimes
                  ruins shadow's results, or a deadlocking bug in tor
 client.
                  i'd say 60% / 40% if i had to guess right now. but i
 oscillate.
 15:28 < armadev> also maybe /sometimes//
 15:28 < nickm> armadev: so, merge the patch or not or wait for something
 else?
 15:29 < armadev> nickm: i think it's fair to say that the simulations for
 6341
                  provided no usable hints about whether to merge it.
 15:30 < nickm> armadev: ok
 15:30 < nickm> armadev: I think I want to put 6341 into needs_information
 then
 15:30 < nickm> agreed?
 15:31 < armadev> sure. i feel a bit bad potentially leaving it out of
 debian's
                  0.2.3. but we shouldn't be too rushed.
 15:31 < nickm> you simultaneously  don't know if we should merge it and
 feel
                bad about not merging it?
 15:32 < nickm> Actually, I know the feeling
 15:32 < armadev> i think it's an actual bug. i think our fix likely fixes
 it. i
                  wonder if our fix breaks something.
 15:32 < nickm> could merge in 0.2.4 and contemplate a backport eventually?
 15:33 < armadev> sounds good to me
 15:33 < nickm> may I copy-and-paste the above?
 15:33 < armadev> sure
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6341#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online