[tor-bugs] #6364 [Tor Client]: Make sure the NETINFO cells include and use IPv6 addresses correctly

[Tor Bug Tracker & Wiki]

#6364: Make sure the NETINFO cells include and use IPv6 addresses correctly
-----------------------------------+----------------------------------------
 Reporter:  ln5                    |          Owner:  ln5         
     Type:  enhancement            |         Status:  needs_review
 Priority:  normal                 |      Milestone:              
Component:  Tor Client             |        Version:              
 Keywords:  SponsorG20120930 ipv6  |         Parent:  #4564       
   Points:                         |   Actualpoints:              
-----------------------------------+----------------------------------------

Comment(by ln5):

 Replying to [comment:7 nickm]:
 > Either add IPv6 fetch; remove IPv4 fetch, or add a comment to the IPv4
 fetch saying that it's broken to be IPv4-only and we need to fix that if
 we ever start using the info.

 Added IPv6 fetch, please see newly updated branch.

 Is the cast to const char* safe?


 > > > When you talk about printing both addresses, do you mean in
 command_process_netinfo_cell() or somewhere else?
 > >
 > > I mean in command_process_netinfo_cell().
 >
 > So, the only one we log is conn->_base.address, which I *think* is the
 one that means the "real" address of this router, yeah?  If so that's ok.

 Yes, you're right. This is actually the other end of the
 connection. I've seen IPv6 addresses in there. We're fine then.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6364#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online