[tor-bugs] #6647 [Tor Client]: pathbias_get_scale_factor() needs to be redone

[Tor Bug Tracker & Wiki]

#6647: pathbias_get_scale_factor() needs to be redone
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:  mikeperry         
     Type:  defect           |         Status:  new               
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:                    
 Keywords:  MikePerry201208  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
 pathbias_get_scale_factor() returns DFLT_PATH_BIAS_SCALE_THRESHOLD instead
 of DFLT_PATH_BIAS_SCALE_FACTOR as the default value.

 This mixup means that every time we hit DFLT_PATH_BIAS_SCALE_THRESHOLD
 worth of path bias data, we basically totally reset our counts.. Woops.

 Also, my analysis from #6135 makes me think I did this whole scaling thing
 wrong. It should be fixed-point decimal value that we multiply with
 instead of a divisor. This will allow us more flexibility, but it will
 also allow us to easily approximate a moving average, which is I think
 probably what we really want. See #6135 and links for details.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6647>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online