[tor-bugs] #6514 [Tor Directory Authority]: Clear rs_out between iterations of voting loop

[Tor Bug Tracker & Wiki]

#6514: Clear rs_out between iterations of voting loop
-------------------------------------+--------------------------------------
 Reporter:  nickm                    |          Owner:                    
     Type:  defect                   |         Status:  needs_review      
 Priority:  normal                   |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------

Comment(by ln5):

 1. I can't see any leakage between iterations in the loop.

 2. I've looked at what's being accessed in routerstatus_format_entry
 and found that to be safe too, since

 - members published_on, nickname, identity_digest, descriptor_digest,
   addr, or_port, dir_port have all been initialised enough in
   networkstatus_compute_consensus()

 and

 - (format == NS_V3_CONSENSUS || format == NS_V3_CONSENSUS_MICRODESC)
   is always true when called from networkstatus_compute_consensus() so
   no other members of the routerstatus is being accessed

 It can be noted that only the first DIGEST_LEN bytes of
 rs->descriptor_digest is initialised. That's enough though since
 digest_to_base64() doesn't read more than that.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6514#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online