[tor-bugs] #6475 [Tor Client]: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes

[Tor Bug Tracker & Wiki]

#6475: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
-----------------------------+----------------------------------------------
 Reporter:  grarpamp         |          Owner:  mikeperry         
     Type:  defect           |         Status:  needs_revision    
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:  Tor: 0.2.3.19-rc  
 Keywords:  MikePerry201208  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by nickm):

 Replying to [comment:18 mikeperry]:
 > nickm: In circuit_finish_handshake() there are log messages and side
 effects (the 'hop' assignment) outside of the main codepath. Should I just
 duplicate the checks in the new function?

 I think that duplicating the checks in the new function and having the hop
 assignment be the only thing thing that happens in
 circuit_finish_handshake()'s if/else blocks would actually make the code
 here much clearer.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6475#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online