[tor-bugs] #6475 [Tor Client]: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes

[Tor Bug Tracker & Wiki]

#6475: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
-----------------------------+----------------------------------------------
 Reporter:  grarpamp         |          Owner:  mikeperry         
     Type:  defect           |         Status:  needs_revision    
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:  Tor: 0.2.3.19-rc  
 Keywords:  MikePerry201208  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by nickm):

  * status:  assigned => needs_revision


Comment:

 Looking at the code:
    * These enum values need good documentation.  There have been SO MANY
 cases where good code turned into a festering morass because we had enum
 values for states where we didn't clearly document what those values were.
    * My inner bit-miser wants to have that enum be a bitfield.
    * The blocks of code for this in circuit_finish_handshake and
 circuit_send_next_onion_skin should be extracted into a new function in a
 separate commit.

 Other than that, seems plausible.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6475#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online