[tor-bugs] #6498 [Metrics Website]: new metrics graph showing number of 100mbit exits

[Tor Bug Tracker & Wiki]

#6498: new metrics graph showing number of 100mbit exits
-----------------------------+----------------------------------------------
 Reporter:  arma             |          Owner:                
     Type:  project          |         Status:  needs_revision
 Priority:  normal           |      Milestone:                
Component:  Metrics Website  |        Version:                
 Keywords:  SponsorJ         |         Parent:                
   Points:                   |   Actualpoints:                
-----------------------------+----------------------------------------------
Changes (by karsten):

  * status:  needs_review => needs_revision


Comment:

 gsathya, I looked at your patch.  Here are some comments:

  - Your last commit, 787e3d4d, should be a "fixup" of 8e08f01.  The two
 commits should get squashed before merging.  (Feel free to rebase your
 branch before my next review if you want.)
  - When you call `stats.get_relays()` you don't pass
 `options.almost_fast_exits_only`, which means that you get all relays, not
 just the almost fast exits.
  - The `--amost-fast-exit-relay` option prints out relays almost failing
 ''both'' bandwidth requirements.  It should instead print out relays
 failing at least one requirement.  Similarly, the port check should
 exclude relays allowing all four ports, because those already meet the
 port requirement instead of almost meeting them.
  - The `-f` flag should become the short form of the `--family` option
 which is contained in another pending patch.  Can you use `-w` instead
 (almost x in the alphabet..)?
  - You're looping over all `or_addresses` to implement the "no more than 2
 relays per /24" requirement.  This is problematic once relays can have two
 or more IPv4 addresses, because then you'll add relays twice or more often
 to the selection.  Fortunately, relays won't have more than one IPv4
 address very soon.  Can you add a loud warning if a relay has more than
 one IPv4 address in that list?
  - Related to `or_addresses` and your `ip.split(':')` command, you're
 treating IPv6 addresses wrongly.  IPv6 addresses for relays will be added
 very soon, so we should handle them correctly, i.e., ignore them entirely
 for the /24 requirement.
  - Just guessing, but I wonder if the script is slow, because you're using
 `socket.inet_aton` to extract the /24 of an address.  Why do the hard math
 there instead of simply cutting off at the last dot?
  - Another idea for the performance problems might be that my ports-
 checking code is quite inefficient.  When I implemented something similar
 in Java yesterday for the graphs, my VM was very unhappy with me.  In
 particular, `reject 1-65535` is the worst case for creating a temporary
 list containing 65535 ints.  Want to look into rewriting that part more
 efficiently?  Otherwise, I'd do it.
  - While you're working on this patch, can you change the bandwidth-rate
 requirement for `--fast-exits-only` from `12500 * 1024` to `95 * 125 *
 1024`, too?  Maybe make that a separate commit.

 Thanks a lot!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6498#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online