[tor-bugs] #6520 [Tor Client]: read_from_old_location is set twice in router_reload_router_list_impl

[Tor Bug Tracker & Wiki]

#6520: read_from_old_location is set twice in router_reload_router_list_impl
-------------------------+--------------------------------------------------
 Reporter:  sysrqb       |          Owner:     
     Type:  enhancement  |         Status:  new
 Priority:  trivial      |      Milestone:     
Component:  Tor Client   |        Version:     
 Keywords:               |         Parent:     
   Points:               |   Actualpoints:     
-------------------------+--------------------------------------------------
 The second mutation appears to exist so that the conditional above it can
 exist. Is there a reason to check the return value?

     read_from_old_location = 1;
     log_notice(LD_DIR, "Couldn't read %s; trying to load routers from old
 "
                "location %s.", fname, altname);
     if ((store->mmap = tor_mmap_file(altname)))
       read_from_old_location = 1;

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6520>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online