[tor-bugs] #2731 [Vidalia]: Relay panel could benefit from more optional columns

[Tor Bug Tracker & Wiki]

#2731: Relay panel could benefit from more optional columns
-------------------------+--------------------------------------------------
 Reporter:  chiiph       |          Owner:  sirop         
     Type:  enhancement  |         Status:  needs_revision
 Priority:  minor        |      Milestone:                
Component:  Vidalia      |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 It's looking better :)

 Two more things:
 - Why are you using Qt's special naming convention to have slots without
 the need of connect() calls, and connecting them too? It seems redundant.
 Also, you should use camelCase names for methods (with normal names), and
 connect them as you are doing already. For example,
 on_chkShowUptime_clicked should be something like chkShowUptimeClicked.
 *But*, with the new loadSettings/saveSettings behavior, is there are real
 need for those slots? Imagine this: what would a user think if she clicks
 on a checkbox and suddenly a column appears/disappears without having to
 press "Save"? It's kind of confusing, don't you think?

 - Regarding the Layout, the Save and Cancel buttons should be stitched to
 the right of the dialog. It's probably a layout issue, if you have, say, a
 GridLayout for the whole settings groupbox, it will stretch as needed and
 you won't have buttons like in your screenshot.

 Keep it up and we will be merging this in no time!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2731#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online