[tor-bugs] #5644 [Tor Client]: rend_service_introduce() asserts circuit->rend_data before checking for proto violation

[Tor Bug Tracker & Wiki]

#5644: rend_service_introduce() asserts circuit->rend_data before checking for
proto violation
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:  #5643             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  new => needs_review


Comment:

 Please see `bug5644` in `https://git.gitorious.org/mytor/mytor.git`.

 I took the most minimal approach and simply dragged the protocol violation
 check to the beginning of the function. It might work.

 I was also tempted to move some stuff below the length check, but I guess
 it was unneeded.

 PS: I couldn't compact the commit message more.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5644#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online