[tor-bugs] #4607 [Tor Hidden Services]: Fix possibly goofy behaviour of intro-circ-creation ratelimiting

[Tor Bug Tracker & Wiki]

#4607: Fix possibly goofy behaviour of intro-circ-creation ratelimiting
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  normal               |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------
Changes (by rransom):

  * status:  new => needs_review


Comment:

 The behaviour described by the old version of that comment is also silly
 -- if Tor has established all the intro points that it wants for a
 service, it won't need to establish more for at least
 `INTRO_CIRC_RETRY_PERIOD` seconds (currently five minutes), so there's no
 point in resetting `service->intro_period_started`.

 See my bug4607 branch for a patch to remove that paragraph of code.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4607#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online