[tor-bugs] #5623 [Tor Client]: directory_initiate_command() can pick a directory mirror which we later refuse as being in ExcludeExitNodes

[Tor Bug Tracker & Wiki]

#5623: directory_initiate_command() can pick a directory mirror which we later
refuse as being in ExcludeExitNodes
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 >I wonder if we want to check if
 routerset_contains_node(options->ExcludeNodes, exit) first? Or is that
 redundant with other checks?

 Should be redundant.  Elsewhere in the function, right up to the end, we
 never return 1, only 0.  And before we return 1, we check for
 routerset_contains_node(options->ExcludeExitNodesUnion,exit).

 We should have a comment for that, I suppose: if it didn't jump out at you
 at your first scan through the function, it is obviously not obvious.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5623#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online