[tor-bugs] #5604 [Tor Client]: If DisableNetwork is set, we open all our ports and then close then at each setconf

[Tor Bug Tracker & Wiki]

#5604: If DisableNetwork is set, we open all our ports and then close then at each
setconf
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 I think the right fix is something like:

     * give retry_all_listeners a flag (or make it notice that
 DisableNetwork is set) to have it not enable any non-Control listeners.
 (It disables any listeners that it doesn't enable IIRC)
     * Leave the connection_mark_all_noncontrol_connections() call alone.

 Does that sound ok?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5604#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online