[tor-bugs] #5607 [Metrics Data Processor]: Bridge descriptor sanitizer calculates wrong descriptor digest

[Tor Bug Tracker & Wiki]

#5607: Bridge descriptor sanitizer calculates wrong descriptor digest
------------------------------------+---------------------------------------
 Reporter:  karsten                 |          Owner:  karsten
     Type:  defect                  |         Status:  new    
 Priority:  normal                  |      Milestone:         
Component:  Metrics Data Processor  |        Version:         
 Keywords:                          |         Parent:         
   Points:                          |   Actualpoints:         
------------------------------------+---------------------------------------
 When [https://gitweb.torproject.org/metrics-
 db.git/blob/9d6c353:/src/org/torproject/ernie/db/SanitizedBridgesWriter.java#l796
 determining SHA-1 hashes of sanitized bridge descriptors in metrics-db] we
 don't include the "router-signature" line.  That means we store sanitized
 bridge descriptors under the wrong file name and reference them from
 bridge network statuses using the wrong descriptor identifier.  The same
 applies to [https://gitweb.torproject.org/metrics-
 db.git/blob/9d6c353:/src/org/torproject/ernie/db/SanitizedBridgesWriter.java#l1014
 extra-info digests].

 This bug isn't problematic as long as one uses descriptor file names to
 navigate between network statuses, server descriptors, and extra-info
 descriptors.  But navigating doesn't work anymore when using metrics-lib's
 getServerDescriptorDigest() or getExtraInfoDigest() methods which
 calculate the SHA-1 digest correctly.  We should fix this bug and sanitize
 all bridge descriptors again.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5607>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online