[tor-bugs] #5603 [Tor Client]: tor doesn't notice some Bridge line edits after SIGHUP
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Wed Apr 11 17:42:05 UTC 2012
#5603: tor doesn't notice some Bridge line edits after SIGHUP
------------------------+---------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
In `bridge_add_from_config()` we call
`get_configured_bridge_by_addr_port_digest()` to check if a carbon-copy
version of the bridge already exists (so that we don't add duplicate
bridges after SIGHUPs).
I think there are two shortcomings in
`get_configured_bridge_by_addr_port_digest()`:
a) It's not pluggable transports aware. If the bridge's transport changes,
tor won't notice it.
b) If a bridge has a fingerprint and it remains the same, but its
address/port changes, tor won't notice it.
{{{
SMARTLIST_FOREACH_BEGIN(bridge_list, bridge_info_t *, bridge)
{
if (tor_digest_is_zero(bridge->identity) &&
!tor_addr_compare(&bridge->addr, addr, CMP_EXACT) &&
bridge->port == port)
return bridge;
if (digest && tor_memeq(bridge->identity, digest, DIGEST_LEN))
return bridge;
}
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5603>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list