[tor-bugs] #4378 [Tor Relay]: Tor guesses IP address when Address is 127.0.0.1

[Tor Bug Tracker & Wiki]

#4378: Tor guesses IP address when Address is 127.0.0.1
-----------------------+----------------------------------------------------
 Reporter:  ln5        |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 > 1. it shouldn't guess

 If I'm reading the code right, "last_guessed_ip" is what we update there.
 We don't actually use it unless we decide to call
 router_guess_address_from_dir_headers, which we only do if
 resolve_my_address() fails entirely.  Perhaps the right behavior, then, is
 that we shouldn't in this case call it a failure from
 resolve_my_address(), but rather simply warn, and refuse to publish?
 Insight wanted.

 > 2. the warning should not be at INFO

 Agreed.  It looks like that warning is controlled by the "warn_severity"
 flag of resolve_my_address(), which is only passed as INFO from router.c,
 in router_pick_published_address, check_descriptor_ipaddress_changed, and
 router_new_address_suggestion.

 The way that it's supposed to work is that when resolve_my_address is
 called earlier (in config.c, I think) it's supposed to give its warnings
 as warnings then, and only subsequently should it complain at INFO.

 Is it workign right?  Did it do the earlier warnings at WARN?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4378#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online