[tor-bugs] #5586 [Obfsproxy]: obfsproxy FTBFS: test suite failure

[Tor Bug Tracker & Wiki]

#5586: obfsproxy FTBFS: test suite failure
-----------------------+----------------------------------------------------
 Reporter:  weasel     |          Owner:  asn             
     Type:  defect     |         Status:  needs_review    
 Priority:  normal     |      Milestone:                  
Component:  Obfsproxy  |        Version:  Obfsproxy: 0.1.3
 Keywords:             |         Parent:                  
   Points:             |   Actualpoints:                  
-----------------------+----------------------------------------------------
Changes (by asn):

  * status:  new => needs_review


Comment:

 Thanks for the bug report.

 I can't reproduce it in an Ubuntu 64-bit system, but I think I found a/the
 problem.
 Can you please test branch `bug5586` in
 `https://git.gitorious.org/obfsproxy/obfsproxy.git`.

 Nick, can you please check if I diagnosed the issue correctly:
 https://gitorious.org/obfsproxy/obfsproxy/commit/598d70e5b6576653caa61b6d322dfb3c0500eb7f
 ?
 IIUC, if you enable `EV_READ` on a bufferevent before it connects to a
 destination and the destination sends traffic to you immediately upon
 connecting, the read callback might trigger before the
 `BEV_EVENT_CONNECTED` event callback. In this case, `downstream_read_cb()`
 was called before `pending_socks_cb()`, and `is_open` was never set to
 true before being asserted in `downstream_read_cb()`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5586#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online