[tor-bugs] #5537 [Tor Client]: client_check_address_changed() looks likely to do badly with ipv6 connections

[Tor Bug Tracker & Wiki]

#5537: client_check_address_changed() looks likely to do badly with ipv6
connections
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  ipv6        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by ln5):

 This looks fine.  Tested on modern Linux with no IPv4 address and seem to
 work too.

 Good catch.

 Actually, it doesn't spam logs because getsockname succeeds, or at
 least returns 0.  Then ip_out becomes 0.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5537#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online