[tor-bugs] #3335 [Tor Hidden Services]: Remove an HS's entries in last_hid_serv_requests when a connection attempt ends

[Tor Bug Tracker & Wiki]

#3335: Remove an HS's entries in last_hid_serv_requests when a connection attempt
ends
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  enhancement          |         Status:  needs_review      
 Priority:  normal               |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by nickm):

 The XXX023 comment notation usually means a potential problem that we need
 to fix before 0.2.3 comes out.  What's the problem with those asserts?

 The documentation for the get_last_hid_serv_requests() strmap and its
 friends really need to get updated for the new strmap key format.

 Is there any way for the new code to result in repeatedly hammering the
 network by trying and failing to connect to the same nonworking hs?  That
 was one of the points of the 15 minute timeout, IIRC.  What replaces that
 functionality now?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3335#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online