[tor-bugs] #4018 [Tor Client]: warn_nonlocal_client_ports should use tor_addr_is_internal, not _is_loopback

[Tor Bug Tracker & Wiki]

#4018: warn_nonlocal_client_ports should use tor_addr_is_internal, not
_is_loopback
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 {{{
 Sep 14 04:11:29.518 [notice] Tor v0.2.3.4-alpha (git-5f4f727d58daa194).
 This is experimental software. Do not rely on it for strong anonymity.
 (Running on OpenBSD i386)
 Sep 14 04:11:29.519 [notice] Read configuration file "/etc/tor/torrc".
 Sep 14 04:11:29.519 [warn] You specified a public address for SocksPort.
 Other people on the Internet might find your computer and use it as an
 open proxy. Please don't allow this unless you have a good reason.
 Sep 14 04:11:29.521 [warn] It's a little hard to tell, but you seem to
 have Libevent 1.4.0-beta header files, whereas you have linked against
 Libevent 1.4.14b-stable.  This will probably make Tor crash.
 Sep 14 04:11:29.523 [notice] Initialized libevent version 1.4.14b-stable
 using method kqueue. Good.
 Sep 14 04:11:29.524 [warn] You specified a public address for SocksPort.
 Other people on the Internet might find your computer and use it as an
 open proxy. Please don't allow this unless you have a good reason.
 Sep 14 04:11:29.524 [notice] Opening Socks listener on 127.0.0.1:9050
 Sep 14 04:11:29.524 [notice] Opening Socks listener on 192.168.7.1:9050
 Sep 14 04:11:29.524 [notice] Opening Control listener on 127.0.0.1:9071
 }}}

 Reported by Tas.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4018>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online