[tor-bugs] #3967 [Torbutton]: new identity feature could support ControlSocket

[Tor Bug Tracker & Wiki]

#3967: new identity feature could support ControlSocket
--------------------------------+-------------------------------------------
 Reporter:  T(A)ILS developers  |          Owner:  mikeperry   
     Type:  enhancement         |         Status:  needs_review
 Priority:  minor               |      Milestone:              
Component:  Torbutton           |        Version:              
 Keywords:                      |         Parent:              
   Points:                      |   Actualpoints:              
--------------------------------+-------------------------------------------
Changes (by mikeperry):

 * cc: lunar (added)


Comment:

 Replying to [comment:2 lunar]:
 > I have just attached a first working attempt of implementing NEWNYM
 through ControlSocket.
 >
 > This is a very crude hack using js-ctypes but it is working
 nevertheless. It currently hardcode almost everything, but I'd like to
 have Mike's opinion before improving this very first attempt.

 Woah.. Did you try to create a file-input-stream and file-output-stream
 xpcom component instead? Is there a reason you can't treat the filesystem
 socket as normal file io? Or perhaps pass the nsIFileInputStream to the
 binary-input-stream, like I did with the socket transport service socket
 in torbutton_send_ctrl_cmd()?

 Looks like https://developer.mozilla.org/en/Code_snippets/File_I%2f%2fO
 has some examples. They all warn about doing sync file IO from the main
 thread, but ctypes is going to be just as bad, and more fragile.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3967#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online